Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localisation catalogue #1999

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

trallard
Copy link
Collaborator

Originally reported in #1997

It seems some localisation strings were not properly updated after some recent theme changes, this PR:

  • Update localisation catalogue
  • Update localisation files

Marking as a block release as it would be ideal to have these updated before the 0.16.0 release.

@trallard trallard added kind: bug Something isn't working impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship tag: i18N Items related to internationalization labels Sep 30, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@Carreau Carreau force-pushed the trallard/update-translation-files branch from 2e48886 to d24ec28 Compare October 1, 2024 07:35
@Carreau
Copy link
Collaborator

Carreau commented Oct 1, 2024

pre-commit is dumb, trying to amend its fix.

@Carreau Carreau added the pre-commit.ci autofix Ask precommit auto autofix and push label Oct 1, 2024
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix Ask precommit auto autofix and push label Oct 1, 2024
@Carreau Carreau force-pushed the trallard/update-translation-files branch from d162671 to b927592 Compare October 1, 2024 07:44
@Carreau
Copy link
Collaborator

Carreau commented Oct 1, 2024

Something is wrong with pre-commit that say it's own commit is invalid, Im going to try force-pushing a older commit to trigger pre-commit from scratch. There are also CI failures from node 16 and/or unicode, but I'm not sure if it's due to pre-commit messing up or not.

@Carreau
Copy link
Collaborator

Carreau commented Oct 1, 2024

All passing now. Merging.

@Carreau Carreau merged commit b38530d into pydata:main Oct 1, 2024
25 checks passed
gabalafou pushed a commit to gabalafou/pydata-sphinx-theme that referenced this pull request Oct 6, 2024
Originally reported in
pydata#1997

It seems some localisation strings were not properly updated after some
recent theme changes, this PR:

- **Update localisation catalogue**
- **Update localisation files**

Marking as a block release as it would be ideal to have these updated
before the `0.16.0` release.
@trallard trallard deleted the trallard/update-translation-files branch October 21, 2024 15:07
@Carreau Carreau added this to the Empty milestone. milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working tag: i18N Items related to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants